这是indexloc提供的服务，不要输入任何密码
Skip to content

added a cli flag to skip update checks, close #1586 #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2019
Merged

added a cli flag to skip update checks, close #1586 #1600

merged 2 commits into from
Feb 14, 2019

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Feb 13, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1586

Solution and Design

Added --skip-update-check bool flag on the root command

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/cli Related to CLI labels Feb 13, 2019
@arvi3411301 arvi3411301 requested a review from shahidhk February 13, 2019 11:32
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 13, 2019

Review app for commit 1f5e336 deployed to Heroku: https://hge-ci-pull-1600.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1600-1f5e336

@shahidhk shahidhk added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Feb 14, 2019
shahidhk
shahidhk approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit d489f2d into hasura:master Feb 14, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2019

Review app https://hge-ci-pull-1600.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Feb 5, 2025
@danieljharvey @hasura-bot
Bake permission checks into OpenDD planning (#1600)
0fdd67b 
<!-- The PR description should answer 2 important questions: -->

### What

We have a lot of holes in permission checks in OpenDD pipeline, what if
we build it into lookups instead? We do this for object types, fixing at
least one known bug on the way.

V3_GIT_ORIGIN_REV_ID: 04d0e03d050e30b9272a58323f3d3821f6f08f73
hasura-bot pushed a commit that referenced this pull request Feb 14, 2025
@danieljharvey @hasura-bot
Add GroupBy to top level OpenDD queries (#1609)
0e23c26 
<!-- The PR description should answer 2 important questions: -->

### What

In #1600 we improved permission checks throughout OpenDD pipeline, with
the side effect of enforcing them for groups. This adds `ModelGroups` to
the `open-dds::query::Query` enum so that we can a test for it directly.

V3_GIT_ORIGIN_REV_ID: 2c8c4c3268d7a7dd2ba415063e0d7d891374005b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arvi3411301 @hasura-bot @shahidhk