fix remote queries/mutations to work over websocket (fix #1619) #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where remote schema queries/mutations would not work over websocket. Error would be returned from the remote server. This is because the server was sending wrong payload to the remote servers.
0x777
reviewed
Mar 5, 2019
| -- try to parse the (apollo protocol) websocket frame and get only the | ||
| -- payload | ||
| sockPayload <- onLeft (J.eitherDecode msgRaw) $ | ||
| const $ withComplete $ sendConnErr "invalid websocket payload" |
Member
There was a problem hiding this comment.
This should be an internal error as we already parsed the request successfully?
Resolve Conflicts: server/src-lib/Hasura/GraphQL/Transport/WebSocket.hs
0x777
approved these changes
Mar 5, 2019
Contributor
|
Review app https://hge-ci-pull-1621.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
<!-- The PR description should answer 2 important questions: --> ### What Fixes the last of the relationships tests for OpenDD. V3_GIT_ORIGIN_REV_ID: 7dbee1c408077f065edf0f9a02826ebebe79663b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue #1619 . This was because the server was sending the wrong payload.
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#1619
Solution and Design
The server was sending the websocket (apollo protocol) payload over http to the remote server. It should send the http payload.
Type
Checklist: