这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@praveenweb
Copy link
Member

@praveenweb praveenweb commented Feb 18, 2019

Description

ace-editor component used in console has an issue where the cursor is off during typing. Related issue is ajaxorg/ace#2548

Added a CSS fix to change font-family.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@praveenweb praveenweb added the c/console Related to console label Feb 18, 2019
@hasura-bot
Copy link
Contributor

Review app for commit f611b05 deployed to Heroku: https://hge-ci-pull-1620.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1620-f611b05

@0x777
Copy link
Member

0x777 commented Feb 19, 2019

Finally the cursor is in the right place on Firefox.

@shahidhk shahidhk merged commit 76b5121 into hasura:master Feb 19, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1620.herokuapp.com is deleted

@praveenweb praveenweb deleted the fix-ace-editor-cursor branch May 21, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants