fix a bug where div keys repetition caused buggy render #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenweb
previously approved these changes
Feb 8, 2019
praveenweb
approved these changes
Feb 8, 2019
Contributor
|
@wawhal @praveenweb you should specify which UI element is affected so that its easy to QA. Esp since this doesnt seem to be linked to an issue or is internally tracked. |
Contributor
|
Review app for commit f7b049c deployed to Heroku: https://hge-ci-pull-1578.herokuapp.com |
Member
|
@karthikvt26 One more review is required, esp. for functionality if it has to be verified. Please review. |
Contributor
|
Review app https://hge-ci-pull-1578.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
<!-- The PR description should answer 2 important questions: --> ### What Push down EXTRACT/DATE_PART function inside GROUP BY. Depends on hasura/ndc-spec#201 ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> --------- Co-authored-by: Daniel Chambers <daniel@hasura.io> V3_GIT_ORIGIN_REV_ID: ccff02132f05de0eb991967c56e0d23bbc69ccfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you open the schema page on data tab in console, the suggested relations are generated with an iteration over a list and the
keyprop to each operator is the left-table of the suggested relation. In cases where relations for multiple tables are suggested, re-rendering is buggy because multiple elements have the samekeyand React looks at thekeyprop while performing incremental renders.Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: