这是indexloc提供的服务，不要输入任何密码
Skip to content

Include function arguments in drop function command to fix (#1548), fix permission tab (#1549) #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 6, 2019
Merged

Include function arguments in drop function command to fix (#1548), fix permission tab (#1549) #1552

merged 5 commits into from
Feb 6, 2019

Conversation

@karthikvt26
Copy link
Contributor

@karthikvt26 karthikvt26 commented Feb 1, 2019 •
edited
Loading

fix #1548, Fix #1549

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@karthikvt26 karthikvt26 mentioned this pull request Feb 1, 2019
Closed
21 tasks
@karthikvt26 karthikvt26 changed the title Include function arguments in drop function command to fix (#1548) Include function arguments in drop function command to fix (#1548), fix permission tab (#1549) Feb 1, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 1, 2019

Review app for commit 894f7f4 deployed to Heroku: https://hge-ci-pull-1552.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1552-894f7f4

@karthikvt26
Copy link
Contributor Author

karthikvt26 commented Feb 4, 2019

Requires changes in the server code which will be fixed in #1547

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2019

Review app for commit b6883f6 deployed to Heroku: https://hge-ci-pull-1552.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1552-b6883f6

rikinsk-zz
rikinsk-zz approved these changes Feb 5, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems fine

@praveenweb praveenweb mentioned this pull request Feb 6, 2019
Closed
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 6, 2019

Review app for commit 135b289 deployed to Heroku: https://hge-ci-pull-1552.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1552-135b289

@rikinsk-zz rikinsk-zz merged commit 39982d4 into hasura:master Feb 6, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 6, 2019

Review app https://hge-ci-pull-1552.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jan 21, 2025
@daniel-chambers @hasura-bot
Move changelog entries into the correct section (#1552)
0872b7f 
### What
Moves the changelog entries from #1542 into unreleased.

V3_GIT_ORIGIN_REV_ID: 10189534a4e68f91f88c928155b2308f9689540f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

+1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

issue with custom function permission tab issue with drop function in postgres < 10

5 participants

@karthikvt26 @hasura-bot @rikinsk-zz @praveenweb @rikinsk