这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: add new install script, commands #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 5, 2019
Merged

cli: add new install script, commands #1556

merged 10 commits into from
Feb 5, 2019

Conversation

@shahidhk
Copy link
Member

@shahidhk shahidhk commented Feb 4, 2019 •
edited by arvi3411301
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@shahidhk shahidhk added c/cli Related to CLI c/docs Related to docs labels Feb 4, 2019
@arvi3411301 arvi3411301 self-requested a review February 4, 2019 11:11
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 4, 2019

Review app for commit 272bd49 deployed to Heroku: https://hge-ci-pull-1556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1556-272bd49

@shahidhk shahidhk requested a review from rikinsk-zz February 5, 2019 05:20
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2019

Review app for commit cd298a0 deployed to Heroku: https://hge-ci-pull-1556.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1556-cd298a0

rikinsk-zz
rikinsk-zz approved these changes Feb 5, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approved

@shahidhk shahidhk merged commit 55cc5fb into hasura:master Feb 5, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2019

Review app https://hge-ci-pull-1556.herokuapp.com is deleted

@Allymahmoud Allymahmoud mentioned this pull request Feb 17, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2023
Open
This was referenced Apr 24, 2023
Open
Open
This was referenced Oct 13, 2023
Open
Open
This was referenced Feb 18, 2024
Open
Open
@Allymahmoud Allymahmoud mentioned this pull request Apr 5, 2024
Open
hasura-bot pushed a commit that referenced this pull request Jan 21, 2025
@danieljharvey @hasura-bot
Remove ast::TypeName from execution plans (#1556)
0182ff0 
<!-- The PR description should answer 2 important questions: -->

### What

We don't have access to `TypeName` from `lang-graphql` in OpenDD, so
let's make sure we don't need it in the execution plan. We only used it
to work out if return types were a) nullable and b) object or array, so
let's just record that information.

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 35aa9f877f8e3cc0d8a5bc4d3e07d3aac99e4420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvi3411301 arvi3411301 arvi3411301 approved these changes

+1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/cli Related to CLI c/docs Related to docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shahidhk @hasura-bot @rikinsk-zz @arvi3411301 @rikinsk