allow json2graphql db.js to export a function to do async stuff inside #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Beep boop! 🤖 Hey @dariocravero, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
Contributor
|
Review app for commit ca67b26 deployed to Heroku: https://hge-ci-pull-1543.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1543.herokuapp.com is deleted |
Contributor
|
Beep boop! 🤖 Whoa! 🎉 🎉 💃 Awesome work @dariocravero! 💪 🏆 All of us at Hasura ❤️ what you did. Thanks again 🤗 |
Contributor
Author
|
Not at all! Thanks to all of you for the amazing work you're doing with
Hasura!!! :)
…On Fri 1 Feb 2019, 11:34 hasura-bot ***@***.*** wrote:
Beep boop! 🤖
Whoa! 🎉 🎉 💃
[image: GIF]
<https://camo.githubusercontent.com/22855e5912f4f6cd2d944575e0a0f259c2184702/68747470733a2f2f6d65646961312e74656e6f722e636f6d2f696d616765732f31356165343132613239346266313238663662613765363061613065613865312f74656e6f722e676966>
Awesome work @dariocravero <https://github.com/dariocravero>! 💪 🏆 All
of us at Hasura ❤️ what you did.
Thanks again 🤗
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1543 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW9zCA9bzwojGj-_5X2eKhf1qKByXwFks5vJCZTgaJpZM4acwOG>
.
|
hasura-bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
<!-- The PR description should answer 2 important questions: --> ### What This was added in #1540 by accident, Cargo ignores it, removing. V3_GIT_ORIGIN_REV_ID: 06546990dc8fd72c57c4700b9d874cc3787c71c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to export a function in
json2graphqlas well as an object, so we can await on it.What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#1488
Solution and Design
If you need to do some asynchronous stuff before exporting your data, you can also export a function:
Type
Checklist: