这是indexloc提供的服务，不要输入任何密码
Skip to content

Improve error message when no operation specs are provided during event trigger creation (close #998) #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2019
Merged

Improve error message when no operation specs are provided during event trigger creation (close #998) #1541

merged 2 commits into from
Feb 1, 2019

Conversation

@nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Jan 31, 2019 •
edited
Loading

Description

Improve the error message when none of the insert/update/delete operation specs are provided

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#998

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 31, 2019

Review app for commit 00a3f55 deployed to Heroku: https://hge-ci-pull-1541.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1541-00a3f55

@0x777 0x777 merged commit 68da491 into hasura:master Feb 1, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 1, 2019

Review app https://hge-ci-pull-1541.herokuapp.com is deleted

@nizar-m nizar-m self-assigned this Mar 7, 2019
hasura-bot pushed a commit that referenced this pull request Jan 17, 2025
@danieljharvey @hasura-bot
Tidy types in plan crate (#1541)
4fe74c7 
<!-- The PR description should answer 2 important questions: -->

### What

The `plan` crate was taken from bits of `sql` crate, and as a result,
uses a bunch of intermediate structs from there which makes what we're
building less clear. This replaces those with returning `ExecutionTree`
everywhere, which will give us a way to return the remote joins and
predicates once we start collecting them.

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 20c067a105eefec2761e03f0d203cec8870d9da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

Assignees

@nizar-m nizar-m

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nizar-m @hasura-bot @tirumaraiselvan @0x777