这是indexloc提供的服务，不要输入任何密码
Skip to content

dont strip x-hasura-access-key from the header for explain query (close #1533) #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

dont strip x-hasura-access-key from the header for explain query (close #1533) #1534

merged 1 commit into from
Jan 31, 2019

Conversation

@karthikvt26
Copy link
Contributor

@karthikvt26 karthikvt26 commented Jan 30, 2019

Fix #1533 and close #1533

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@karthikvt26 karthikvt26 mentioned this pull request Jan 30, 2019
Closed
@shahidhk shahidhk changed the title Dont strip x-hasura-access-key from the header for explain/analyze query fix #1533 dont strip x-hasura-access-key from the header for explain query (fix #1533) Jan 30, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 30, 2019

Review app for commit eefea3d deployed to Heroku: https://hge-ci-pull-1534.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1534-eefea3d

@shahidhk shahidhk added c/console Related to console k/bug Something isn't working labels Jan 31, 2019
@shahidhk shahidhk changed the title dont strip x-hasura-access-key from the header for explain query (fix #1533) dont strip x-hasura-access-key from the header for explain query (close #1533) Jan 31, 2019
shahidhk
shahidhk approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x777 0x777 merged commit 1268ef6 into hasura:master Jan 31, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 31, 2019

Review app https://hge-ci-pull-1534.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jan 16, 2025
@paritosh-08 @hasura-bot
Reapply "allow reusing order by expressions across different models" … (
4bc30e6 
#1534)

…(#1505)

This reverts commit 4fb606d222802bd749779be2322f09055b7cdbed.

<!-- The PR description should answer 2 important questions: -->

### What

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

<!-- Does this PR introduce new validation that might break old builds?
-->

<!-- Consider: do we need to put new checks behind a flag? -->

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

V3_GIT_ORIGIN_REV_ID: ee29a63e7452928a84005e2cf08fe6883c61fa66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

c/console Related to console k/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analize query does not work when X-Hasura-Access-Key is set in the graphql-engine

4 participants

@karthikvt26 @hasura-bot @shahidhk @0x777