add config for stringified hasura claims in JWT (fix #1176) #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is required, as some providers like AWS Cognito allows only strings in custom claims.
Contributor
|
Review app for commit 2855566 deployed to Heroku: https://hge-ci-pull-1538.herokuapp.com |
0x777
reviewed
Feb 5, 2019
docs/graphql/manual/auth/jwt.rst
Outdated
| "jwk_url": "<optional-url-to-refresh-jwks>", | ||
| "claims_namespace": "<optional-key-name-in-claims>" | ||
| "claims_namespace": "<optional-key-name-in-claims>", | ||
| "is_stringified": <optional-boolean> |
Member
There was a problem hiding this comment.
or claims_format? can be one of json/stringified_json. The default can be json.
0x777
reviewed
Feb 5, 2019
|
|
||
| validateIsObject jVal = | ||
| parseObjectFromString isStrngfd jVal = | ||
| case jVal of |
Member
There was a problem hiding this comment.
case (isStrngFd, jVal) of
(True, String x) -> string parsing logic
(True, _) -> "expecting a string when the format is stringified_json"
(False, Object o) -> return o
(False, _) -> "expecting a json object when the format is json"Something along those lines. More readable.
0x777
reviewed
Feb 5, 2019
| (JCFJson, _) -> | ||
| throw400 JWTInvalidClaims "expecting a json object when claims_format is json" | ||
|
|
||
| strngfdErr = "Could not parse JSON string under: '" |
Member
There was a problem hiding this comment.
Something simpler like: "expecting stringified json at" <> loc <> "but found: " <> v?
0x777
reviewed
Feb 5, 2019
| instance Show JWTCtx where | ||
| show (JWTCtx _ nsM audM) = | ||
| show ["<IORef JWKSet>", show nsM, show audM] | ||
| show (JWTCtx _ nsM audM strfd) = |
Member
There was a problem hiding this comment.
remove references to strfd, isstrngfd?
0x777
approved these changes
Feb 5, 2019
Contributor
|
Review app https://hge-ci-pull-1538.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
<!-- The PR description should answer 2 important questions: --> ### What Fix relationships to model aggregates V3_GIT_ORIGIN_REV_ID: e00c5d382f3429447920b41bb2854a8a88d0ac1a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for AWS Cognito JWT
Add config option (
claims_format) to indicate if the hasura specific claims in JWT are stringified.This is required, as some providers like AWS Cognito allow only strings in custom claims.
Default :
json.When
stringified_json, Hasura will expect stringified hasura claims:{ "sub": "1234567890", "name": "John Doe", "admin": true, "iat": 1516239022, "https://hasura.io/jwt/claims": "{\"x-hasura-allowed-roles\":[\"editor\",\"user\",\"mod\"],\"x-hasura-default-role\":\"user\",\"x-hasura-user-id\":\"1234567890\",\"x-hasura-org-id\":\"123\",\"x-hasura-custom\":\"custom-value\"}" }What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#1176
Solution and Design
Type
Checklist: