这是indexloc提供的服务，不要输入任何密码
Skip to content

do not allow overloading already tracked functions #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 14, 2019
Merged

do not allow overloading already tracked functions #1563

merged 8 commits into from
Feb 14, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Feb 5, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #1560

Solution and Design

Raise an exception if any tracked function being overloaded.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Feb 5, 2019
@rakeshkky rakeshkky self-assigned this Feb 5, 2019
@rakeshkky rakeshkky requested a review from 0x777 February 5, 2019 20:24
@rakeshkky rakeshkky mentioned this pull request Feb 5, 2019
Closed
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2019

Review app for commit 48683fb deployed to Heroku: https://hge-ci-pull-1563.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1563-48683fb

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 8, 2019

Review app for commit af88b7a deployed to Heroku: https://hge-ci-pull-1563.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1563-af88b7a

0x777
0x777 reviewed Feb 11, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2019

Review app for commit d97dbc9 deployed to Heroku: https://hge-ci-pull-1563.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1563-d97dbc9

0x777
0x777 reviewed Feb 11, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2019

Review app for commit d79d799 deployed to Heroku: https://hge-ci-pull-1563.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1563-d79d799

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2019

Review app for commit 5f1ea92 deployed to Heroku: https://hge-ci-pull-1563.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1563-5f1ea92

@0x777 0x777 merged commit 2054bdc into hasura:master Feb 14, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2019

Review app https://hge-ci-pull-1563.herokuapp.com is deleted

@Allymahmoud Allymahmoud mentioned this pull request Feb 17, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2023
Open
This was referenced Apr 24, 2023
Open
Open
This was referenced Oct 13, 2023
Open
Open
@Allymahmoud Allymahmoud mentioned this pull request Feb 18, 2024
Open
@Allymahmoud Allymahmoud mentioned this pull request Feb 19, 2024
Open
@Allymahmoud Allymahmoud mentioned this pull request Apr 5, 2024
Open
hasura-bot pushed a commit that referenced this pull request Jan 23, 2025
@danieljharvey @hasura-bot
Enable a bunch more execution tests we missed (#1563)
d578a7e 
<!-- The PR description should answer 2 important questions: -->

### What

A load of tests have been fixed by other changes such as remote
relationships, let's enable them!

V3_GIT_ORIGIN_REV_ID: 74e78c01bda3ab17a354e797b2d35ada3b2e16be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

issue with modifying custom function

3 participants

@rakeshkky @hasura-bot @0x777