这是indexloc提供的服务，不要输入任何密码
Skip to content

fix add-column button overflow in modify table #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 11, 2019
Merged

fix add-column button overflow in modify table #1518

merged 11 commits into from
Feb 11, 2019

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Jan 29, 2019 •
edited
Loading

The Add Column button on Modify Table page was overflowing the border of the parent div. This PR fixes it.

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@wawhal wawhal added k/bug Something isn't working c/console Related to console labels Jan 29, 2019
@wawhal wawhal requested a review from praveenweb January 29, 2019 13:33
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 29, 2019

Review app for commit c873e52 deployed to Heroku: https://hge-ci-pull-1518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1518-c873e52

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 30, 2019

Review app for commit 29fe7bb deployed to Heroku: https://hge-ci-pull-1518.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1518-29fe7bb

rikinsk-zz
rikinsk-zz approved these changes Feb 11, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks good

@wawhal wawhal added the s/ok-to-merge Status: This pull request can be merged to master label Feb 11, 2019
@shahidhk shahidhk merged commit 61aa39e into hasura:master Feb 11, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2019

Review app https://hge-ci-pull-1518.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jan 13, 2025
@danieljharvey @hasura-bot
Build single-architecture images for Cloud (#1518)
9f67102 
<!-- The PR description should answer 2 important questions: -->

### What

The `ddn-engine-local-dev` image and friends all need to be
multi-architecture builds, but the rest don't need to be, so let's save
some building time.

V3_GIT_ORIGIN_REV_ID: 05eb1be81194b1a7cc2eb0731d2232be41e4d272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

+1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console k/bug Something isn't working s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wawhal @hasura-bot @rikinsk-zz @praveenweb @shahidhk