这是indexloc提供的服务，不要输入任何密码
Skip to content

add delivery info to event payload (close #1476) #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2019
Merged

add delivery info to event payload (close #1476) #1517

merged 2 commits into from
Feb 7, 2019

Conversation

@tirumaraiselvan
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan commented Jan 29, 2019

Description

Adds the following to the event payload:

    "delivery_info": {
        "max_retries": 0,
        "current_retry": 0
    }

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1476

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@tirumaraiselvan tirumaraiselvan changed the title add delivery info to event payload add delivery info to event payload (close #1476) Jan 29, 2019
@tirumaraiselvan tirumaraiselvan force-pushed the event-trigger-retry-info branch from cdece77 to 777c867 Compare January 29, 2019 11:25
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 29, 2019

Review app for commit 777c867 deployed to Heroku: https://hge-ci-pull-1517.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1517-777c867

0x777
0x777 reviewed Feb 4, 2019
View reviewed changes
server/src-lib/Hasura/Events/Lib.hs Outdated
, epCreatedAt :: Time.UTCTime
} deriving (Show, Eq)

instance ToJSON EventPayload where
Copy link
Member

@0x777 0x777 Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap QualifiedTable in an newtype and implement ToJSON typeclass.

@tirumaraiselvan tirumaraiselvan force-pushed the event-trigger-retry-info branch from 9ac98d3 to c1da315 Compare February 7, 2019 11:34
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 7, 2019

Review app for commit c1da315 deployed to Heroku: https://hge-ci-pull-1517.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1517-c1da315

@shahidhk shahidhk merged commit 9a6fa7f into hasura:master Feb 7, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 7, 2019

Review app https://hge-ci-pull-1517.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tirumaraiselvan @hasura-bot @0x777 @shahidhk