这是indexloc提供的服务，不要输入任何密码
Skip to content

remove wreq and set response timeout (close #1477) #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 14, 2019
Merged

remove wreq and set response timeout (close #1477) #1501

merged 18 commits into from
Feb 14, 2019

Conversation

@tirumaraiselvan
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan commented Jan 28, 2019 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1477

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@tirumaraiselvan tirumaraiselvan requested a review from 0x777 January 28, 2019 15:22
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit 1c2d6ef deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-1c2d6ef

@ecthiender ecthiender added the c/server Related to server label Jan 28, 2019
@tirumaraiselvan tirumaraiselvan force-pushed the event-trigger-configure-timeout branch from 1c2d6ef to bea4103 Compare January 29, 2019 07:53
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 29, 2019

Review app for commit c6e634b deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-c6e634b

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 29, 2019

Review app for commit 52f2d83 deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-52f2d83

@wawhal wawhal requested a review from praveenweb January 29, 2019 14:33
@shahidhk shahidhk added c/console Related to console c/docs Related to docs labels Jan 29, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 30, 2019

Review app for commit 0c0496c deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-0c0496c

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 30, 2019

Review app for commit b836919 deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-b836919

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 30, 2019

Review app for commit b00cf13 deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-b00cf13

praveenweb
praveenweb reviewed Jan 31, 2019
View reviewed changes
praveenweb
praveenweb reviewed Jan 31, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 31, 2019

Review app for commit 3d13c5f deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-3d13c5f

praveenweb
praveenweb previously approved these changes Feb 1, 2019
View reviewed changes
0x777
0x777 reviewed Feb 5, 2019
View reviewed changes
server/src-lib/Hasura/Events/Lib.hs
let EventEngineCtx _ c _ _ = eeCtx
modifyTVar' c (\v -> v - 1)

finally <- liftIO $ runExceptT $ case eitherResp of
Copy link
Member

@0x777 0x777 Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap this logic in a function like persistInvocationResult?

Copy link
Member

@0x777 0x777 Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runFailureQ, runSuccessQ doesn't tell much about what they do

@tirumaraiselvan
Merge branch 'master' of github.com:hasura/graphql-engine into event-…
e0cdfba 
…trigger-configure-timeout

# Conflicts:
#	server/src-lib/Hasura/Events/Lib.hs
@tirumaraiselvan
Merge branch 'event-trigger-configure-timeout' of github.com:tirumara…
786cc3d 
…iselvan/graphql-engine into event-trigger-configure-timeout
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 7, 2019

Review app for commit 1787d08 deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-1787d08

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2019

Review app for commit a361615 deployed to Heroku: https://hge-ci-pull-1501.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1501-a361615

@shahidhk shahidhk merged commit 51dd615 into hasura:master Feb 14, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2019

Review app https://hge-ci-pull-1501.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jun 17, 2021
@plcplc @hasura-bot
Generalize set_table_customization to other backends (close #1501)
73e5c6c 
hasura/graphql-engine-mono#1591

GitOrigin-RevId: 4233279
hasura-bot pushed a commit that referenced this pull request Jan 14, 2025
@danieljharvey @hasura-bot
Nested object selections into OpenDD IR (#1501)
ca10a26 
<!-- The PR description should answer 2 important questions: -->

### What

Make object nested selections work in GraphQL -> OpenDD IR pipeline.

V3_GIT_ORIGIN_REV_ID: 727ebd9ca4b2c91424bda78135c9db940c05676e
hasura-bot pushed a commit that referenced this pull request Jan 14, 2025
@danieljharvey @hasura-bot
Query commands in OpenDD IR (#1498)
b1b9638 
<!-- The PR description should answer 2 important questions: -->

### What

Basic function command in GraphQL OpenDD pipeline.

Nested on #1501

V3_GIT_ORIGIN_REV_ID: 451702b6495af4ff4a2ca5c7aca3d3123bf3542a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console c/docs Related to docs c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tirumaraiselvan @hasura-bot @0x777 @praveenweb @ecthiender @shahidhk @wawhal