这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@danielcompton
Copy link
Contributor

--address was ambiguous as to whether it referred to the console/migrations API the CLI is running or the endpoint of the actual GraphQL engine.

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Fixes #1507.

Solution and Design

This change clarifies the command line flag.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2019

CLA assistant check
All committers have signed the CLA.

--address was ambiguous as to whether it referred to the console/migrations
API the CLI is running or the endpoint of the actual GraphQL engine.

Fixes hasura#1507.
@shahidhk shahidhk added the c/cli Related to CLI label Jan 29, 2019
@shahidhk shahidhk changed the title Clarify hasura-cli console --address flag update help text for console command Jan 29, 2019
@shahidhk shahidhk merged commit a5c9347 into hasura:master Jan 29, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1508.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @danielcompton! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/cli Related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify --address in Hasura console CLI

4 participants