这是indexloc提供的服务，不要输入任何密码
Skip to content

Support default values (in inputvalue) from the remote schema (close #1491) #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2019
Merged

Support default values (in inputvalue) from the remote schema (close #1491) #1493

merged 3 commits into from
Jan 28, 2019

Conversation

@nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Jan 28, 2019

Description

Show the default values from the remote schema

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1491

Solution and Design

  • Parse the default values from the remote schema.
  • Add support for default values in the InputValue data type
  • During introspection, convert the default value as a GraphQL encoded string.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

0x777
0x777 previously approved these changes Jan 28, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit 6645b3a deployed to Heroku: https://hge-ci-pull-1493.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1493-6645b3a

@0x777 0x777 merged commit 8e3b8f5 into hasura:master Jan 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app https://hge-ci-pull-1493.herokuapp.com is deleted

@0x777 0x777 added this to the v1.0.0-alpha36 milestone Jan 28, 2019
hasura-bot pushed a commit that referenced this pull request Jan 7, 2025
@rakeshkky @hasura-bot
Integrate openDd IR in graphql aggregate selection (#1493)
0170ca1 
<!-- The PR description should answer 2 important questions: -->
### What

Enable OpenDd request pipeline for GraphQL aggregate selection
selection.

V3_GIT_ORIGIN_REV_ID: 392c118e94a72393d9f4de082de157687e0f38db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0-alpha36

Development

Successfully merging this pull request may close these issues.

3 participants

@nizar-m @hasura-bot @0x777