这是indexloc提供的服务，不要输入任何密码
Skip to content

test jwt with invalid signtaure and expired token (close #1429) #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

test jwt with invalid signtaure and expired token (close #1429) #1492

merged 1 commit into from
Jan 28, 2019

Conversation

@ecthiender
Copy link
Contributor

@ecthiender ecthiender commented Jan 28, 2019

Description

Added tests for JWT with invalid signature and expired token.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Server tests

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1429

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@ecthiender ecthiender requested a review from nizar-m January 28, 2019 09:35
nizar-m
nizar-m approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@nizar-m nizar-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit e653841 deployed to Heroku: https://hge-ci-pull-1492.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1492-e653841

@shahidhk shahidhk merged commit 91c19ec into hasura:master Jan 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app https://hge-ci-pull-1492.herokuapp.com is deleted

@ecthiender ecthiender mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nizar-m nizar-m nizar-m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ecthiender @hasura-bot @nizar-m @shahidhk