这是indexloc提供的服务，不要输入任何密码
Skip to content

support column presets in update mutation and restrict altering type of preset columns (close #1449, fix #1464) #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 11, 2019
Merged

support column presets in update mutation and restrict altering type of preset columns (close #1449, fix #1464) #1473

merged 17 commits into from
Feb 11, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Jan 25, 2019 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

close #1449
fix #1464

Solution and Design

  1. Allow specifying predefined values for columns in update permissions.
  2. Restrict altering type of preset column through run_sql (fixes issue Meta-data in column presets not updating after modification of a column type #1464)
  3. args field of create_update_permission query type has optional set field.
    It takes json object and defaults to empty json object ({})

Metadata API:-

POST /v1/query
{
	"type": "create_update_permission",
	"args": {
		"table": "author",
		"role": "user-state",
		"permission": {
			"filter": {},
			"columns": "*",
			
			"set": {
				"state": "karnataka"
			}
		}
	}
}

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added c/console Related to console c/server Related to server labels Jan 25, 2019
@rakeshkky rakeshkky self-assigned this Jan 25, 2019
@rakeshkky rakeshkky requested a review from 0x777 January 25, 2019 12:07
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 25, 2019

Review app for commit 53505ce deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-53505ce

@rakeshkky rakeshkky changed the title support column presets in update mutation (close #1449) support column presets in update mutation and restrict modifying type of preset columns (close #1449, fix #1464) Jan 25, 2019
@rakeshkky rakeshkky changed the title support column presets in update mutation and restrict modifying type of preset columns (close #1449, fix #1464) support column presets in update mutation and restrict altering type of preset columns (close #1449, fix #1464) Jan 25, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 25, 2019

Review app for commit 84c00ab deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-84c00ab

@rakeshkky
Merge branch 'master' into issue-1449-upd-presets
adc5363 
Resolve Conflicts:
	server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit adc5363 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-adc5363

@wawhal wawhal added the s/do-not-merge Do not merge this pull request to master label Jan 28, 2019
@wawhal wawhal requested a review from karthikvt26 January 28, 2019 14:29
wawhal and others added 4 commits January 28, 2019 20:48
@wawhal
replace checkbox with chevron in col presets
69a2ead
@wawhal
add datatest for col presets
1119ba9
@rakeshkky
Merge branch 'master' into issue-1449-upd-presets
541550b 
Resolve Conflicts:
	console/src/components/Services/Data/TablePermissions/Permissions.js
	server/src-lib/Hasura/RQL/DDL/Permission/Internal.hs
@wawhal
change data-test to chevron
d2f9e04
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 29, 2019

Review app for commit d2f9e04 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-d2f9e04

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 29, 2019

Review app for commit 60bddfe deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-60bddfe

karthikvt26
karthikvt26 requested changes Feb 1, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 1, 2019

Review app for commit 5a2905a deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-5a2905a

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 1, 2019

Review app for commit ee53e28 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-ee53e28

karthikvt26
karthikvt26 previously approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console functionality looks good.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 4, 2019

Review app for commit 0f2dae0 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-0f2dae0

@wawhal wawhal force-pushed the issue-1449-upd-presets branch from 0f2dae0 to d2c5d20 Compare February 4, 2019 10:41
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 4, 2019

Review app for commit d2c5d20 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-d2c5d20

rikinsk-zz
rikinsk-zz previously approved these changes Feb 4, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating/modifying presets looks fine

@wawhal wawhal removed the s/do-not-merge Do not merge this pull request to master label Feb 5, 2019
0x777
0x777 reviewed Feb 8, 2019
View reviewed changes
karthikvt26
karthikvt26 previously approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakeshkky rakeshkky dismissed stale reviews from karthikvt26 and rikinsk-zz via ba07592 February 8, 2019 10:53
@rakeshkky rakeshkky requested a review from praveenweb as a code owner February 8, 2019 10:53
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 8, 2019

Review app for commit ba07592 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-ba07592

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2019

Review app for commit 6b86521 deployed to Heroku: https://hge-ci-pull-1473.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1473-6b86521

praveenweb
praveenweb approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works. LGTM.

@0x777 0x777 merged commit cba732d into hasura:master Feb 11, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 11, 2019

Review app https://hge-ci-pull-1473.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Jan 2, 2025
@rakeshkky @hasura-bot
Update graphql-ws architecture.md (#1473)
bfc00ce 
Updates the `architecture.md` file in `graphql-ws` crate.

V3_GIT_ORIGIN_REV_ID: d32724c80fe70a049d5d460b80bca44e130f7720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@praveenweb praveenweb praveenweb approved these changes

@karthikvt26 karthikvt26 karthikvt26 left review comments

+2 more reviewers

@wawhal wawhal wawhal left review comments

@rikinsk-zz rikinsk-zz rikinsk-zz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rakeshkky rakeshkky

Labels

c/console Related to console c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Meta-data in column presets not updating after modification of a column type Support for column presets in UPDATES

7 participants

@rakeshkky @hasura-bot @rikinsk-zz @0x777 @praveenweb @karthikvt26 @wawhal