这是indexloc提供的服务，不要输入任何密码
Skip to content

console ui fixes #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 28, 2019
Merged

console ui fixes #1455

merged 7 commits into from
Jan 28, 2019

Conversation

@praveenweb
Copy link
Member

@praveenweb praveenweb commented Jan 24, 2019 •
edited
Loading

Description

  • API Explorer input box readonly and cursor changes
  • Focus on schema dropdown firefox fix
  • Border bottom on scroll for react-table fixed
  • Left sidebar table scrollbar fix for firefox

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@praveenweb praveenweb added the c/console Related to console label Jan 24, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app for commit a0a42ed deployed to Heroku: https://hge-ci-pull-1455.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1455-a0a42ed

karthikvt26
karthikvt26 reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot 662

Should also be fixed by this?

@praveenweb
Copy link
Member Author

praveenweb commented Jan 24, 2019

@karthikvt26 - Sure, missed that one. @surendran82 - Let's add this fix too.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app for commit 935b6ad deployed to Heroku: https://hge-ci-pull-1455.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1455-935b6ad

karthikvt26
karthikvt26 reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue with the UI when scroll is present

screenshot 664

URL: https://hge-ci-pull-1455.herokuapp.com/console/data/schema/public/tables/author/browse

Edit: This issue occurs in firefox only. Chrome is fine

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app for commit 02be532 deployed to Heroku: https://hge-ci-pull-1455.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1455-02be532

karthikvt26
karthikvt26 reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot 665
The border is off for the last cell: https://hge-ci-pull-1455.herokuapp.com/console/data/schema/public/tables/author/browse

Also event triggers left side bar has a scroll

screenshot 666

https://hge-ci-pull-1455.herokuapp.com/console/events/manage/triggers

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app for commit 3e47bcd deployed to Heroku: https://hge-ci-pull-1455.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1455-3e47bcd

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit 0c312c4 deployed to Heroku: https://hge-ci-pull-1455.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1455-0c312c4

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Jan 28, 2019
@shahidhk shahidhk merged commit 33b8c3d into hasura:master Jan 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app https://hge-ci-pull-1455.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Dec 17, 2024
@rakeshkky @hasura-bot
no-op refactor: lift process_command_relationship_definition to ope…
dc13603 
…ndd planning (#1455)

<!-- The PR description should answer 2 important questions: -->

### What

Move `process_command_relationship_definition` to opendd planning code
path. This also requires the `LocalCommandRelationshipInfo` type to be
moved.

This is a no-op refactor and incremental PR towards supporting command
relationship in opendd query resolution.

### How

Just refactor and move stuff.

V3_GIT_ORIGIN_REV_ID: 1ef74c71e3be335e276873306637384cfb63e821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikvt26 karthikvt26 karthikvt26 approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@praveenweb @hasura-bot @karthikvt26 @shahidhk @surendran82