fix a bug where modifying trigger opts failed #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvi3411301
approved these changes
Jan 24, 2019
Contributor
|
Review app for commit 25546ac deployed to Heroku: https://hge-ci-pull-1465.herokuapp.com |
Contributor
|
Review app for commit 4becdcb deployed to Heroku: https://hge-ci-pull-1465.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1465.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
<!-- The PR description should answer 2 important questions: --> ### What This PR adds the boring plumbing to allow us to start using the OpenDD pipeline for GraphQL. Functional no-op for users. We add: - an unstable feature `--unstable feature enable-open-dd-pipeline-for-graphql` for single-tenant engine - an enum in `ModelSelectMany` in `graphql-ir` that allows us to either plan and execute with the new pipeline. Currently it explodes if used as we need to modify the GraphQL -> OpenDD IR functions in `graphql-frontend` and use those. This PR is big enough. - we make `metadata_resolve::Metadata` available when planning a GraphQL request so it can be used by `plan` crate What's next? - Change engine GraphQL tests so they run old / new pipeline and compare results - Remove old way of testing OpenDD pipeline - Start making OpenDD and GraphQL work, starting with `ModelSelectMany` V3_GIT_ORIGIN_REV_ID: 62ca59616230d1b84f5734b8a3af25cb18fc2ee7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: