这是indexloc提供的服务，不要输入任何密码
Skip to content

support jsonb and postgis operators in permissions #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 28, 2019
Merged

support jsonb and postgis operators in permissions #1461

merged 6 commits into from
Jan 28, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Jan 24, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Close #1408

Solution and Design

  1. Support all PostGIS and jsonb (except _has_keys_all and _has_keys_any) in
    RQL query (/v1/query)
  2. To support _has_keys_all and _has_keys_any, we need to find a solution to parse
    session variable values, which are String values, as postgres arrays

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added c/console Related to console c/server Related to server labels Jan 24, 2019
@rakeshkky rakeshkky self-assigned this Jan 24, 2019
@rakeshkky rakeshkky requested a review from 0x777 January 24, 2019 13:31
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app for commit 766e709 deployed to Heroku: https://hge-ci-pull-1461.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1461-766e709

0x777
0x777 reviewed Jan 28, 2019
View reviewed changes
@rakeshkky
Merge branch 'master' into issue-1408-rql-ops
46869c0 
Resolve Conflicts:
	server/src-lib/Hasura/RQL/GBoolExp.hs
	server/tests-py/queries/graphql_query/permissions/teardown.yaml
@rakeshkky
improve parsing $st_d_within op's json value logic
698f76b
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit 698f76b deployed to Heroku: https://hge-ci-pull-1461.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1461-698f76b

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app for commit de7df98 deployed to Heroku: https://hge-ci-pull-1461.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1461-de7df98

@shahidhk shahidhk merged commit 3caff9b into hasura:master Jan 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 28, 2019

Review app https://hge-ci-pull-1461.herokuapp.com is deleted

@shahidhk shahidhk mentioned this pull request Jan 28, 2019
Closed
hasura-bot pushed a commit that referenced this pull request Dec 19, 2024
@rakeshkky @hasura-bot
jsonapi: move test snapshots to test folders (#1461)
854eaeb 
### What
No-op refactor similar to hasura/v3-engine#1454

V3_GIT_ORIGIN_REV_ID: 9b63b8e42be89cba158e0a0b061d04e5dec99249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/console Related to console c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

operators exposed through rql and graphql interfaces should be the same

4 participants

@rakeshkky @hasura-bot @0x777 @shahidhk