这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Jan 18, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1370

Solution and Design

Provide instructions for running py-test

  • Install required python packages
  • Set the required environmental variables
  • Run the GraphQL engine locally
  • Run pytest

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@nizar-m nizar-m changed the title Update Test section in Server Contributing.md (close #1370) Update Server Contributing.md (close #1370) Jan 18, 2019
@0x777 0x777 merged commit bf67e5e into hasura:master Jan 20, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1414.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Review app for commit 5130e16 deployed to Heroku: https://hge-ci-pull-1414.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1414-5130e16

hasura-bot pushed a commit that referenced this pull request Dec 9, 2024
<!-- The PR description should answer 2 important questions: -->

### What

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

<!-- Does this PR introduce new validation that might break old builds?
-->

<!-- Consider: do we need to put new checks behind a flag? -->

This PR introduces pre-route plugins. A pre-route plugin sits at the
router level. It will catch all the OTHER routes (other than existing
routes like `/graphql`, `/v1/explain`, etc.) and, based on the
configuration, call some external webhook to handle the request.

Currently, we can configure the following:

- The regex for the URL to match on
- The request to the webhook:
  - headers
  - method
  - raw query

The feature is currently hidden behind a flag.

In case of multiple pre-route plugins, the first matching pre-route
plugin will handle the request.

Currently, the pre-route plugin can handle only GET requests to the
engine, but we can easily expand this to handle other requests.

A sample request being handled by the preroute plugin:

![image](https://github.com/user-attachments/assets/1c7d96bd-72cd-41ae-abe7-b703cbac41ae)

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

We have made the following changes:
- Make our tracing library more lenient for trace span names.
- Implement the middleware.

V3_GIT_ORIGIN_REV_ID: cc9913c7071a65c2da545f11909f72fccd798862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants