update cli contributing guide #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsandip
previously approved these changes
Jan 20, 2019
cli/CONTRIBUTING.md
Outdated
| [`good-first-issue`](https://github.com/hasura/graphql-engine/issues?q=is%3Aissue+is%3Aopen+label%3Ac%2Fcli+label%3A%22good+first+issue%22) label for issues that | ||
| are fairly easy to implement. | ||
|
|
||
| For new contributors to get started quickly, we encourage one-on-one |
Member
There was a problem hiding this comment.
@shahidhk Can't do suggestions over multiple lines 🙄 . Here's what I recommend for this para:
For first-time contributors, we have set aside some time slots for one-on-one pair programming with the team, to get you started quickly :). If you're interested in setting up a chat, please feel free to pick a slot from [shahidhk](https://github.com/shahidhk)'s
[calendar](https://calendly.com/shahidhk).
Member
Author
|
Done.
Regards,
Shahidh
…On Sun, 20 Jan 2019 at 20:51, dsandip ***@***.***> wrote:
***@***.**** approved this pull request.
@shahidhk <https://github.com/shahidhk> suggestions only.
------------------------------
In cli/CONTRIBUTING.md
<#1412 (comment)>
:
> @@ -2,10 +2,23 @@
Thanks for your interest in Hasura GraphQL Engine CLI.
+The CLI is written in [Go](https://golang.org/) using the popular
+package [`spf13/cobra`](https://github.com/spf13/cobra).
+
+All CLI related issues are labelled as [`c/cli`](https://github.com/hasura/graphql-engine/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Ac%2Fcli+) which stands for
+component/cli. If you're new to the CLI codebase, you can checkout the
+[`good-first-issue`](https://github.com/hasura/graphql-engine/issues?q=is%3Aissue+is%3Aopen+label%3Ac%2Fcli+label%3A%22good+first+issue%22) label for issues that
+are fairly easy to implement.
+
+For new contributors to get started quickly, we encourage one-on-one
@shahidhk <https://github.com/shahidhk> Can't do suggestions over
multiple lines 🙄 . Here's what I recommend for this para:
For first-time contributors, we have set aside some time slots for one-on-one pair programming with the team, to get you started quickly :). If you're interested in setting up a chat, please feel free to pick a slot from [shahidhk](https://github.com/shahidhk)'s
[calendar](https://calendly.com/shahidhk).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1412 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD7wPTd714QebyZLOhtZ5SzCtaHs8voHks5vFIlwgaJpZM4aHoqO>
.
|
Contributor
|
Review app https://hge-ci-pull-1412.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
<!-- The PR description should answer 2 important questions: --> ### What Parse the LIKE operator and push down standard operator names. This does not include any standardization of operator meanings which needs to happen on the NDC side, but we can do that along with comparison operators. ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: 4d203d2a6a75396b05f81538584caa4fb2f99104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: