这是indexloc提供的服务，不要输入任何密码
Skip to content

create correct down migration for delete_event_trigger action (close #1390) #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2019
Merged

create correct down migration for delete_event_trigger action (close #1390) #1391

merged 5 commits into from
Jan 24, 2019

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Jan 16, 2019 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1390

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console labels Jan 16, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 18, 2019

Review app for commit ac21d0c deployed to Heroku: https://hge-ci-pull-1391.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1391-ac21d0c

@dsandip
Copy link
Member

dsandip commented Jan 20, 2019

@praveenweb is this good to go after the review?

praveenweb
praveenweb approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Jan 22, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 22, 2019

Review app for commit cb22cc3 deployed to Heroku: https://hge-ci-pull-1391.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1391-cb22cc3

@shahidhk shahidhk changed the title fix to create correct down migration for delete_event_trigger action (close #1390) create correct down migration for delete_event_trigger action (close #1390) Jan 24, 2019
@shahidhk shahidhk merged commit b5b2fe6 into hasura:master Jan 24, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 24, 2019

Review app https://hge-ci-pull-1391.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-1390 branch January 26, 2019 10:57
hasura-bot pushed a commit that referenced this pull request Nov 29, 2024
@daniel-chambers @hasura-bot
Fix model permissions not being applied across relationships in boole…
b43e6f5 
…an expressions (#1391)

### What
This PR corrects an issue where model permissions are not applied to
models used via relationships in boolean expressions.

### How
The permissions are now correctly read out of the GraphQL schema
annotations and combined with the query's predicate in
`crates/graphql/ir/src/filter.rs`.

Existing tests that test relationships in boolean expressions have been
updated to test this scenario.

V3_GIT_ORIGIN_REV_ID: a6b39ec81695dcfe5a84b40369d04ac26acad7fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arvi3411301 @hasura-bot @dsandip @praveenweb @shahidhk