这是indexloc提供的服务，不要输入任何密码
Skip to content

add css property to completely show column values (close #1246) #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2019
Merged

add css property to completely show column values (close #1246) #1337

merged 1 commit into from
Jan 11, 2019

Conversation

@WickedBrat
Copy link
Contributor

@WickedBrat WickedBrat commented Jan 7, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 7, 2019

Beep boop! 🤖

Hey @WickedBrat1, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@WickedBrat WickedBrat changed the title Minor fix for table body width add a css property to fix visible table body view (fixes #1246) Jan 7, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 7, 2019

Review app for commit 666960d deployed to Heroku: https://hge-ci-pull-1337.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1337-666960d

@praveenweb praveenweb added c/console Related to console s/ok-to-merge Status: This pull request can be merged to master labels Jan 8, 2019
@WickedBrat WickedBrat changed the title add a css property to fix visible table body view (fixes #1246) add css property to complely show column values (fixes #1246) Jan 8, 2019
@WickedBrat WickedBrat changed the title add css property to complely show column values (fixes #1246) add css property to complely show column values (close #1246) Jan 8, 2019
@shahidhk shahidhk changed the title add css property to complely show column values (close #1246) add css property to completely show column values (close #1246) Jan 11, 2019
@shahidhk shahidhk merged commit 406df14 into hasura:master Jan 11, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 11, 2019

Review app https://hge-ci-pull-1337.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 11, 2019

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @WickedBrat1! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WickedBrat @hasura-bot @praveenweb @shahidhk