这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Jan 7, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1307
#1308
#1332

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/console Related to console labels Jan 7, 2019
@arvi3411301 arvi3411301 requested a review from praveenweb January 7, 2019 14:54
@hasura-bot
Copy link
Contributor

Review app for commit 4ff9871 deployed to Heroku: https://hge-ci-pull-1336.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1336-4ff9871

Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Jan 8, 2019
@shahidhk shahidhk changed the title [Event Triggers] Bug fixes console bug fixes on event triggers page (close #1307) (close #1308) (close #1332) Jan 8, 2019
@shahidhk shahidhk merged commit a2b40de into hasura:master Jan 8, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1336.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-1308 branch January 8, 2019 11:31
hasura-bot pushed a commit that referenced this pull request Nov 12, 2024
<!-- The PR description should answer 2 important questions: -->

### What

Operator mappings in boolean expressions allow us to override the name
of an operator, so we can call some database's `_eq` operator the much
more attractive `equals`. If not override is provided we can just use
the database's name directly. We make this a newtype with a `get`
function to encode this logic and make doing the right thing the easiest
thing.

V3_GIT_ORIGIN_REV_ID: e47f4e291494562ed1551d0d7469259198862a0a
hasura-bot pushed a commit that referenced this pull request Nov 14, 2024
<!-- The PR description should answer 2 important questions: -->

### What

Previously the OpenDD pipeline has ignored `BooleanExpressionType` as
they were not available outside GraphQL. Now they are, so we use them,
and test them in the JSONAPI pipeline.

This means that the SQL frontend cannot use filtering unless models have
a `BooleanExpressionType` defined. These are generated by the CLI, so
hopefully this is fine.

Depends on #1336

V3_GIT_ORIGIN_REV_ID: 4037585ef36bc99c99a482361084ccd09c5c6bb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants