这是indexloc提供的服务，不要输入任何密码
Skip to content

remove permission-denied check for login redirect (close #1364) #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2019
Merged

remove permission-denied check for login redirect (close #1364) #1363

merged 2 commits into from
Jan 12, 2019

Conversation

@praveenweb
Copy link
Member

@praveenweb praveenweb commented Jan 11, 2019 •
edited
Loading

Description

When the server returns permission-denied for any requests, the console used to redirect to login page. This was applicable for older versions of server where the server used to return permission-denied code when the access key was incorrectly given by the user.

Now the server returns access-denied code correctly in the recent versions (after alpha19) and hence this check is not required in console anymore.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1364

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 self-requested a review January 11, 2019 13:30
@arvi3411301 arvi3411301 added the c/console Related to console label Jan 11, 2019
@praveenweb praveenweb changed the title remove permission-denied check for login redirect remove permission-denied check for login redirect (close #1364) Jan 11, 2019
arvi3411301
arvi3411301 previously approved these changes Jan 11, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 11, 2019

Review app for commit d5a1f14 deployed to Heroku: https://hge-ci-pull-1363.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1363-d5a1f14

@arvi3411301 arvi3411301 added the s/ok-to-merge Status: This pull request can be merged to master label Jan 11, 2019
@shahidhk shahidhk merged commit f7d408e into hasura:master Jan 12, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 12, 2019

Review app https://hge-ci-pull-1363.herokuapp.com is deleted

@praveenweb praveenweb deleted the fix-permission-denied branch May 21, 2019 06:58
hasura-bot pushed a commit that referenced this pull request Nov 20, 2024
@danieljharvey @hasura-bot
Add new execution plan types to plan-types crate (#1363)
e6f56f8 
<!-- The PR description should answer 2 important questions: -->

### What

Adds the types required for the new execution planning to the
`plan-types` crate. Some of these lived in `graphql-ir`, so have been
removed from there. Functional no-op.

V3_GIT_ORIGIN_REV_ID: 0e39aca2d35a7fe69382363b2cef8a028e9be86e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvi3411301 arvi3411301 arvi3411301 approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@praveenweb @hasura-bot @arvi3411301 @shahidhk