ensure foreign_key_constraint_on exists (fix #1278)
#1315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Beep boop! 🤖 Hey @iam4x, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
when defining a manual relationship on a table that has a self referencing array relationship the console ui was crashing because we were trying to access the property `foreign_key_constraint_on` which does not exists on a muan relationship
Contributor
|
Review app for commit 689da73 deployed to Heroku: https://hge-ci-pull-1315.herokuapp.com |
Contributor
|
Review app for commit df43797 deployed to Heroku: https://hge-ci-pull-1315.herokuapp.com |
Contributor
Contributor
|
Review app https://hge-ci-pull-1315.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
<!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> Fix a bug with pollers are not being stopped when the connection is dropped. ### How Fetch all poller operation ids at once from a mutex map and stop each poller associated with them in a for-loop. <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: f17511d611b92ace3de2c83e606d26214649878b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when defining a manual relationship on a table
that has a self referencing array relationship the
console ui was crashing because we were trying to access
the property
foreign_key_constraint_onwhich does not existson a manual relationship
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#1278
Solution and Design
Add a check in the condition before accessing an undefined value
Type
Checklist: