这是indexloc提供的服务，不要输入任何密码
Skip to content

migrate apply inserts into schema_migration only once per version (fix #127) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018
Merged

migrate apply inserts into schema_migration only once per version (fix #127) #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cli/commands/migrate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ func testMigrate(t *testing.T, endpoint *url.URL, migrationsDir string) {
table: test
type: untrack_table
`)
mustWriteFile(t, migrationsDir, "2_add_table_test.up.sql", `CREATE TABLE "author"("id" serial NOT NULL, PRIMARY KEY ("id") )`)
mustWriteFile(t, migrationsDir, "2_add_table_test.down.sql", `DROP TABLE "author";`)

// Apply 1_create_table_test.up.sql
testMigrateApply(t, endpoint, migrationsDir, "1", "", "", "")
Expand Down
15 changes: 10 additions & 5 deletions cli/migrate/migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ func (m *Migrate) readDown(limit int64, ret chan<- interface{}) {
// to stop execution because it might have received a stop signal on the
// GracefulStop channel.
func (m *Migrate) runMigrations(ret <-chan interface{}) error {
var lastInsertVersion int64
for r := range ret {
if m.stop() {
return nil
Expand All @@ -799,14 +800,18 @@ func (m *Migrate) runMigrations(ret <-chan interface{}) error {
return err
}

if int64(migr.Version) == migr.TargetVersion {
// Insert Version number into the table
if err := m.databaseDrv.InsertVersion(int64(migr.Version)); err != nil {
return err
version := int64(migr.Version)
if version == migr.TargetVersion {
if version != lastInsertVersion {
// Insert Version number into the table
if err := m.databaseDrv.InsertVersion(version); err != nil {
return err
}
lastInsertVersion = version
}
} else {
// Delete Version number from the table
if err := m.databaseDrv.RemoveVersion(int64(migr.Version)); err != nil {
if err := m.databaseDrv.RemoveVersion(version); err != nil {
return err
}
}
Expand Down