这是indexloc提供的服务，不要输入任何密码
Skip to content

ui improvements on event trigger update columns (close #1257) #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2019
Merged

ui improvements on event trigger update columns (close #1257) #1259

merged 3 commits into from
Jan 3, 2019

Conversation

@surendran82
Copy link
Contributor

@surendran82 surendran82 commented Dec 21, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1257

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@surendran82 surendran82 added s/do-not-merge Do not merge this pull request to master c/console Related to console labels Dec 21, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 21, 2018

Review app for commit 99c4dae deployed to Heroku: https://hge-ci-pull-1259.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1259-99c4dae

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 2, 2019

Review app for commit 86ce8ac deployed to Heroku: https://hge-ci-pull-1259.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1259-86ce8ac

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Jan 3, 2019
@shahidhk shahidhk changed the title UI improvement on event trigger update columns, fix #1257 ui improvements on event trigger update columns (close #1257) Jan 3, 2019
@shahidhk shahidhk merged commit 79de014 into hasura:master Jan 3, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 3, 2019

Review app https://hge-ci-pull-1259.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Oct 22, 2024
@danieljharvey @hasura-bot
Include TypeRepresentation in resolved scalar types (#1259)
97f96bc 
<!-- The PR description should answer 2 important questions: -->

### What

To generate JSONAPI OpenAPI spec we need to know the underlying type
representation of custom types. This is (optionally) provided by a data
connector in it's `scalar_types` section. It's really annoying to look
up, so let's collect them all and store them on the
`ScalarTypeRepresentation`, keyed by `Qualified<DataConnectorName>`.

No functional change, this will be used in JSONAPI OpenAPI generation
shortly.

V3_GIT_ORIGIN_REV_ID: 084304a580aca977e1f8c39b16938205a49b1b0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@surendran82 @hasura-bot @praveenweb @shahidhk @arvi3411301