local console during development #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2018 19:33
1. local console assets can be served at /static/ by a build time flag 'local-console'. This can be set with stack as follows: `stack build --flag graphql-engine:local-console` 2. the --root-dir option is removed which was used as a temporary hack for serving graphiql
Contributor
|
Review app for commit 328f85f deployed to Heroku: https://hge-ci-pull-1252.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1252.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
<!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> - Propagate baggage across span links and push websocket id into baggage. - Attach usage analytics attributes to execute span. ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> - First, move setting usage attributes into a separate function. Re-use it in websockets code. - Open a new `execute` span within the `websocket_execute_query` and attach usage attributes to it. - Add support to propagate trace baggage across span links. Push websocket id into trace baggage. - Remove setting `websocket.id` attribute in new linked traces as the tracer will set websocket.id in baggage as an attribute. V3_GIT_ORIGIN_REV_ID: 96338d8b9b3eb2f927e3ca57336e8372093ab585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console can now be served by local builds of the server
Description
During local development, console can be served by following these steps:
Build console assets
cd console npm ciBuild the server as follows:
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: