这是indexloc提供的服务，不要输入任何密码
Skip to content

add update-cli command to cli (close #1239) #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 4, 2019
Merged

add update-cli command to cli (close #1239) #1251

merged 14 commits into from
Feb 4, 2019

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Dec 20, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1239

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added s/do-not-merge Do not merge this pull request to master c/cli Related to CLI labels Dec 20, 2018
@arvi3411301 arvi3411301 requested a review from shahidhk December 20, 2018 13:54
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 20, 2018

Review app for commit 8a23803 deployed to Heroku: https://hge-ci-pull-1251.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1251-8a23803

shahidhk
shahidhk previously requested changes Jan 3, 2019
View reviewed changes
cli/commands/update.go Outdated
}
updateCmd := &cobra.Command{
Use: "update-cli",
Short: "Update graphql-engine CLI tool to latest version",
Copy link
Member

@shahidhk shahidhk Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-word to Update the Hasura CLI to latest version.

cli/commands/update.go Outdated
}

func (o *updateOptions) run() error {
isUpdate, releaseInfo, asset, err := update.CheckUpdate(o.EC.Version.GetCLIVersion())
Copy link
Member

@shahidhk shahidhk Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change isUpdate to hasUpdate

@shahidhk
Copy link
Member

shahidhk commented Jan 3, 2019

@arvi3411301 How do we test this?

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 3, 2019

Review app for commit d78dab9 deployed to Heroku: https://hge-ci-pull-1251.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1251-d78dab9

@shahidhk shahidhk changed the title add update-cli command to cli tool (close #1239) add update-cli command to cli (close #1239) Jan 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 31, 2019

Review app for commit 8a53cd3 deployed to Heroku: https://hge-ci-pull-1251.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1251-8a53cd3

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 31, 2019

Review app for commit f7e55c2 deployed to Heroku: https://hge-ci-pull-1251.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1251-f7e55c2

@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Feb 2, 2019
@shahidhk shahidhk dismissed their stale review February 2, 2019 09:18

irrelevant

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 2, 2019

Review app for commit e709186 deployed to Heroku: https://hge-ci-pull-1251.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1251-e709186

@shahidhk shahidhk merged commit 20be2e5 into hasura:master Feb 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 4, 2019

Review app https://hge-ci-pull-1251.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Oct 21, 2024
@paritosh-08 @hasura-bot
disallow defining boolean expression of array fields with scalar bool…
90780c0 
…ean type (#1251)

<!-- The PR description should answer 2 important questions: -->

### What

This PR adds a check to disallow defining boolean expression of array
fields with scalar boolean type while resolving the boolean expression
`comparable_fields`.

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

V3_GIT_ORIGIN_REV_ID: e9fd2feaff5a20d05b51b9ccd2a460f2b7e767dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arvi3411301 @hasura-bot @shahidhk