这是indexloc提供的服务，不要输入任何密码
Skip to content

improve startup log (close #1236) #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2019
Merged

improve startup log (close #1236) #1258

merged 3 commits into from
Jan 2, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Dec 21, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

close #1236

Solution and Design

Now startup logs looks like this.

{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"serve_options","info":{"auth_hook_mode":null,"unauth_role":null,"accesskey_set":false,"enable_console":false,"auth_hook":null,"cors_disabled":false,"cors_domain":"*","port":8080}}}                         
{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"postgres_connection","info":{"database":"test","user":"postgres","host":"localhost","port":5432}}}
{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"db_init","info":"successfully initialised"}}           
{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"db_migrate","info":"already at the latest version"}}   
{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"event_triggers","info":"preparing data"}}              
{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"event_triggers","info":"starting workers"}}            
{"timestamp":"2018-12-21T16:09:04.118+0530","level":"info","type":"startup","detail":{"kind":"server","info":"starting API server"}}

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky
improve startup logging, close hasura#1236
93a3951
@rakeshkky
Merge branch 'master' into issue-1236-startup-log
3d84124 
Resolve Conflicts:
	server/src-exec/Main.hs
	server/src-lib/Hasura/Server/App.hs
@rakeshkky rakeshkky requested a review from 0x777 December 21, 2018 10:42
@rakeshkky rakeshkky self-assigned this Dec 21, 2018
@rakeshkky rakeshkky added c/server Related to server s/ok-to-merge Status: This pull request can be merged to master labels Dec 21, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 21, 2018

Review app for commit 3d84124 deployed to Heroku: https://hge-ci-pull-1258.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1258-3d84124

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 2, 2019

Review app for commit 50e65d9 deployed to Heroku: https://hge-ci-pull-1258.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1258-50e65d9

@0x777 0x777 merged commit 4d9d150 into hasura:master Jan 2, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 2, 2019

Review app https://hge-ci-pull-1258.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Oct 22, 2024
@paritosh-08 @hasura-bot
fix changelog for last release (#1258)
997d147 
<!-- The PR description should answer 2 important questions: -->

### What

This PR fixes the changelog for the last release. An entry was added
accidently to the already-released version instead of the unreleased
section.

### How

By moving the changelog line.

V3_GIT_ORIGIN_REV_ID: 0d2edeea1890da90eee5d4475c78a4541b6fc7b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix logging during startup

3 participants

@rakeshkky @hasura-bot @0x777