revert back to older cli options parser type #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit 5554b7a deployed to Heroku: https://hge-ci-pull-1231.herokuapp.com |
0x777
reviewed
Dec 19, 2018
server/src-exec/Main.hs
Outdated
| printYaml = BC.putStrLn . Y.encode | ||
|
|
||
| printVersion :: RavenMode -> IO () | ||
| printVersion :: HGECommand -> IO () |
Member
There was a problem hiding this comment.
This fn need not take HGECommand as an arg, why not write this logic at the location where we are calling this fn?
Contributor
|
Review app for commit a222b70 deployed to Heroku: https://hge-ci-pull-1231.herokuapp.com |
0x777
approved these changes
Dec 19, 2018
Contributor
|
Review app for commit 95d2f3f deployed to Heroku: https://hge-ci-pull-1231.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1231.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Revert back to older
Parsertype. Get rid ofConfigMmonad.ParserMmonad inopt-parse applicativepackage is sequential, hence it expectsall command line options to be present in order.
Type
Checklist: