这是indexloc提供的服务，不要输入任何密码
Skip to content

persist headers in graphiQL tab (close #275) #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2019
Merged

persist headers in graphiQL tab (close #275) #1262

merged 4 commits into from
Jan 4, 2019

Conversation

@CodHeK
Copy link
Contributor

@CodHeK CodHeK commented Dec 21, 2018 •
edited by praveenweb
Loading

persist headers setting in graphiQL tab added.
(fix #275)

Description

Added headers that are set into localStorage, and loaded the headers that already present from localStorage.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 21, 2018

Beep boop! 🤖

Hey @CodHeK, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CodHeK CodHeK changed the title persist_headers_(fix_#275) persist headers setting in graphiQL tab_(fix_#275) Dec 21, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 21, 2018

Review app for commit e283b7e deployed to Heroku: https://hge-ci-pull-1262.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1262-e283b7e

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 22, 2018

Review app for commit 708f5c3 deployed to Heroku: https://hge-ci-pull-1262.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1262-708f5c3

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 22, 2018

Review app for commit dfbdecb deployed to Heroku: https://hge-ci-pull-1262.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1262-dfbdecb

praveenweb
praveenweb reviewed Jan 2, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 2, 2019

Review app for commit 59dab7e deployed to Heroku: https://hge-ci-pull-1262.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1262-59dab7e

@praveenweb praveenweb added the c/console Related to console label Jan 3, 2019
praveenweb
praveenweb approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Jan 3, 2019
@shahidhk shahidhk changed the title persist headers setting in graphiQL tab_(fix_#275) persist headers in graphiQL tab (close #275) Jan 4, 2019
@shahidhk shahidhk merged commit 92ff16a into hasura:master Jan 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 4, 2019

Review app https://hge-ci-pull-1262.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 4, 2019

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @CodHeK! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: persist headers setting in graphiQL tab

4 participants

@CodHeK @hasura-bot @praveenweb @shahidhk