这是indexloc提供的服务，不要输入任何密码
Skip to content

show response status code in event trigger events tab (close #1022) #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 15, 2018
Merged

show response status code in event trigger events tab (close #1022) #1203

merged 5 commits into from
Dec 15, 2018

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Dec 13, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1022

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added c/console Related to console s/do-not-merge Do not merge this pull request to master labels Dec 13, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 13, 2018

Review app for commit 40bfaef deployed to Heroku: https://hge-ci-pull-1203.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1203-40bfaef

karthikvt26
karthikvt26 reviewed Dec 14, 2018
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 14, 2018

Review app for commit 70c0efa deployed to Heroku: https://hge-ci-pull-1203.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1203-70c0efa

@arvi3411301 arvi3411301 added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Dec 14, 2018
@shahidhk shahidhk changed the title show response status code in event trigger events tab, close #1022 show response status code in event trigger events tab (close #1022) Dec 15, 2018
@shahidhk shahidhk merged commit 432a151 into hasura:master Dec 15, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 15, 2018

Review app https://hge-ci-pull-1203.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-1022 branch December 17, 2018 07:49
hasura-bot pushed a commit that referenced this pull request Oct 4, 2024
@danieljharvey @hasura-bot
Move plan types out of GraphQL IR (#1203)
ad6c47a 
<!-- The PR description should answer 2 important questions: -->

### What

A lot of the `graphql_ir` is generally useful and not GraphQL specific.
Before we can move it into `plan` and share it we need to pull a few
shared types out of the package and somewhere more general too.

### How

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 3fe8ca737ef3d8c7ce09ea695453645e303d7030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikvt26 karthikvt26 karthikvt26 approved these changes

@tirumaraiselvan tirumaraiselvan Awaiting requested review from tirumaraiselvan

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arvi3411301 @hasura-bot @tirumaraiselvan @karthikvt26 @shahidhk