这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rakeshkky
Copy link
Member

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Server templates consolePath key in window.__env object in console html template.
If server is hit at /console/table/author then window.__env in served html looks like

{
   consoleMode: "server",
   urlPrefix: "/console",
   consolePath: "/console/table/author",
   isAccessKeySet: true
}

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Dec 17, 2018
@rakeshkky rakeshkky self-assigned this Dec 17, 2018
@rakeshkky rakeshkky requested a review from 0x777 December 17, 2018 12:32
@hasura-bot
Copy link
Contributor

Review app for commit 3ca0197 deployed to Heroku: https://hge-ci-pull-1222.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1222-3ca0197

0x777
0x777 previously approved these changes Dec 17, 2018
@0x777 0x777 added this to the v1.0.0-alpha32 milestone Dec 17, 2018
@hasura-bot
Copy link
Contributor

Review app for commit f40c34d deployed to Heroku: https://hge-ci-pull-1222.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1222-f40c34d

@shahidhk shahidhk added the c/console Related to console label Dec 18, 2018
@hasura-bot
Copy link
Contributor

Review app for commit cd13eb4 deployed to Heroku: https://hge-ci-pull-1222.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1222-cd13eb4

Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit b5bbb96 into hasura:master Dec 18, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1222.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants