determine api root from consolepath var on console #1228
Conversation
|
Review app for commit 06a1f6a deployed to Heroku: https://hge-ci-pull-1228.herokuapp.com |
| if (globals.nodeEnv !== 'development') { | ||
| const windowUrl = window.location.protocol + '//' + window.location.host; | ||
| globals.dataApiUrl = windowUrl; | ||
| if (window.__env.consolePath) { |
There was a problem hiding this comment.
add this env in helpers/Html.js
|
Review app for commit bf7d78f deployed to Heroku: https://hge-ci-pull-1228.herokuapp.com |
|
Review app https://hge-ci-pull-1228.herokuapp.com is deleted |
|
@shahidhk Do I need to set any environment variable to get this working? I have exactly this issue. I want to server the console on http:///something/console. I couldn't find the information in the docs. |
|
@mastoj No, this should be taken care of automatically. You just have to put a reverse proxy in front of Hasura and forward requests to Hasura without the URL prefix. |
|
@shahidhk you're completely right, but I couldn't get the nginx proxy to work the way I wanted in combination with ingress on kubernetes. I did however get it to work after switching from nginx to traefik. |
|
Heads up to anyone trying to serve graphql-engine behind an nginx reverse proxy and a URL prefix: You need to append a slash to the upstream URL in proxy_pass. Without the trailing slash the graphql-engine will return an error. |
|
Given @KloudJack 's setup with Visiting |
<!-- The PR description should answer 2 important questions: --> ### What This PR enables argument presets in the OpenDD pipeline by using functions from `graphql_ir`. In the ideal future we'd flip the dependency and move these functions out of `graphql_ir` and into the `plan` crate, however we can't do that until `execute` crate is no longer in active development as it will involve making a big mess there. ### How - Calculate argument presets in the `plan/query/model_target` module using functions from `graphql_ir` - We also begin adding boolean expression resolve, then back away slowly as it's a massive job and better tackled when we start making `where` clauses work in this pipeline, to stop this PR ballooning insanely. V3_GIT_ORIGIN_REV_ID: 47867452b7366e83f71b118e37302de93d9bde72
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: