add json editor for json data type (fix #504) #1181
Conversation
|
Beep boop! 🤖 Hey @Anupam-dagar, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
|
@shahidhk can you suggest toggle icon for this also? |
|
Review app for commit 91dab00 deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
Review app for commit e891e88 deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
The editor does not show up on edit. It only works for insert.
…On Fri, 21 Dec 2018 at 5:23 PM, hasura-bot ***@***.***> wrote:
Review app for commit e891e88
<e891e88>
deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1181-e891e88
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1181 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIAWHzxrC8SzgW8NsmKTT5nZDYszF_Rks5u7MuugaJpZM4ZNHQN>
.
|
|
@coco98 missed that part. I'll add it. |
This adds a generic input to json editor toggle component. Fixes: 504
|
Review app for commit f8fd882 deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
@coco98 added editor in edit. |
|
@Anupam-dagar is it ready? I think it's very useful feature 😉 |
|
Deploy preview for hasura-docs ready! Built with commit 5a4143d |
|
Review app for commit 6dac0d8 deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
Review app for commit dfb6eec deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
Review app for commit 122c99d deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
Review app for commit a6a0fa0 deployed to Heroku: https://hge-ci-pull-1181.herokuapp.com |
|
Review app https://hge-ci-pull-1181.herokuapp.com is deleted |
|
Beep boop! 🤖 Whoa! 🎉 🎉 💃 Awesome work @Anupam-dagar! 💪 🏆 All of us at Hasura ❤️ what you did. Thanks again 🤗 |
<!-- The PR description should answer 2 important questions: -->
### What
<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->
<!-- Consider: do we need to add a changelog entry? -->
<!-- Does this PR introduce new validation that might break old builds?
-->
<!-- Consider: do we need to put new checks behind a flag? -->
Create a new trace for each subscription poll and link the span. It is
done to avoid accumulation of polling spans in one trace. Also, move
waiting for poll interval to post execution.
### How
- Update `in_span_async_with_link` to `new_trace_async_with_link` which
signifies opening a new trace with a link.
- Wrap the body present `loop {}` in `new_trace_async_with_link` to emit
new trace for each poll.
- Capture poll exceptions in the trace.
<!-- How is it trying to accomplish it (what are the implementation
steps)? -->
V3_GIT_ORIGIN_REV_ID: c984ef70e0e55a5edae12e3f3c0580a0065516cd
This adds a generic input to json editor toggle component.
Fixes: #504
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Solution and Design
Type
Checklist: