这是indexloc提供的服务，不要输入任何密码
Skip to content

handle cross schema permissions in console permission builder #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2018
Merged

handle cross schema permissions in console permission builder #1158

merged 5 commits into from
Dec 3, 2018

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Dec 3, 2018 •
edited
Loading

Description

Close #1127 #1152

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rikinsk-zz rikinsk-zz requested a review from praveenweb December 3, 2018 09:22
@rikinsk-zz rikinsk-zz added the c/console Related to console label Dec 3, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2018

Review app for commit 754929a deployed to Heroku: https://hge-ci-pull-1158.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1158-754929a

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Dec 3, 2018
@rikinsk-zz rikinsk-zz merged commit 1e24da8 into hasura:master Dec 3, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2018

Review app https://hge-ci-pull-1158.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the permissions-fix branch December 3, 2018 12:48
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2018

Review app for commit 8726204 deployed to Heroku: https://hge-ci-pull-1158.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1158-8726204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating relationships across schemas does not show them in the permissions builder

4 participants

@rikinsk-zz @hasura-bot @praveenweb @rikinsk