这是indexloc提供的服务，不要输入任何密码
Skip to content

suggested relationship name shouldn't strips off numbers (close #1139) #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2018
Merged

suggested relationship name shouldn't strips off numbers (close #1139) #1144

merged 2 commits into from
Nov 30, 2018

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Nov 29, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1139

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added the c/console Related to console label Nov 29, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 29, 2018

Review app for commit b0a8fe0 deployed to Heroku: https://hge-ci-pull-1144.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1144-b0a8fe0

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 29, 2018

Review app for commit af144f2 deployed to Heroku: https://hge-ci-pull-1144.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1144-af144f2

@arvi3411301 arvi3411301 added the s/ok-to-merge Status: This pull request can be merged to master label Nov 29, 2018
@shahidhk shahidhk changed the title suggested relationship name shouldn't strips off numbers suggested relationship name shouldn't strips off numbers (close #1139) Nov 30, 2018
@shahidhk shahidhk merged commit 980d203 into hasura:master Nov 30, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 30, 2018

Review app https://hge-ci-pull-1144.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-1139 branch January 3, 2019 10:56
hasura-bot pushed a commit that referenced this pull request Sep 24, 2024
@danieljharvey @hasura-bot
Use ddn-engine as Otel name (#1144)
017d6a0 
<!-- The PR description should answer 2 important questions: -->

### What

We've been using `graphql-engine` as our OpenTelemetry application name,
which makes differentiating from V2 difficult, this changes it to use
`ddn-engine` instead.

V3_GIT_ORIGIN_REV_ID: 95870dd6799f1e43b88ba593308aa4bacb62ca2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arvi3411301 @hasura-bot @praveenweb @shahidhk