这是indexloc提供的服务，不要输入任何密码
Skip to content

added support for file information in hasuradb driver (close #1136) #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 3, 2018
Merged

added support for file information in hasuradb driver (close #1136) #1143

merged 7 commits into from
Dec 3, 2018

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Nov 29, 2018 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1136

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Nov 29, 2018
@arvi3411301 arvi3411301 requested a review from shahidhk November 29, 2018 12:20
@arvi3411301 arvi3411301 changed the title added support for file information in hasuradb driver, close #1136 added support for file information in hasuradb driver Nov 29, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 29, 2018

Review app for commit 6f5accb deployed to Heroku: https://hge-ci-pull-1143.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1143-6f5accb

@arvi3411301 arvi3411301 changed the title added support for file information in hasuradb driver added support for file information in hasuradb driver (close #1136) Nov 30, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 30, 2018

Review app for commit 7904180 deployed to Heroku: https://hge-ci-pull-1143.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1143-7904180

@shahidhk
Copy link
Member

shahidhk commented Dec 3, 2018

Depends on #1149

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2018

Review app for commit 661378f deployed to Heroku: https://hge-ci-pull-1143.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1143-661378f

@shahidhk shahidhk merged commit 6d2fd1d into hasura:master Dec 3, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2018

Review app https://hge-ci-pull-1143.herokuapp.com is deleted

@arvi3411301 arvi3411301 mentioned this pull request Dec 3, 2018
Closed
@arvi3411301 arvi3411301 deleted the issue-1136 branch January 3, 2019 10:57
hasura-bot pushed a commit that referenced this pull request Sep 23, 2024
@ecthiender @hasura-bot
remote joins: monomorphize Location type (#1143)
23e10ae 
### What

`Location`/`JoinLocations` types were polymorphic, so as to contain
`RemoteJoin` or `(RemoteJoin, JoinId)`. Since we've removed `JoinId` we
can make the types simpler and make them monomorphic.

Functional no-op.

### How

V3_GIT_ORIGIN_REV_ID: 69243ab6cbf350ca787a0a236d0b2676f503fd89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arvi3411301 @hasura-bot @shahidhk