console semver check fix for non-tag versions #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit e5d5636 deployed to Heroku: https://hge-ci-pull-1134.herokuapp.com |
Member
|
|
Member
|
@shahidhk - yeah the semver package version has changed in package.json (we have freezed to a particular version) and hence package-lock needs to be updated. LGTM |
praveenweb
approved these changes
Dec 3, 2018
Contributor
|
Review app for commit 5502621 deployed to Heroku: https://hge-ci-pull-1134.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1134.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…1134) <!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> - Introduce a brand new `graphql-ws` crate that implements - WebSocket request handling by `WebSocketServer` struct - [graphql-ws](https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md) protocol and handles subscriptions in async tokio tasks. - OSS engine now handles GraphQL websockets through `GET /graphql` handshakes. ### How Refer to added [architecture.md](https://github.com/hasura/v3-engine/blob/rakeshkky/graphql-ws-crate/crates/graphql-ws/architecture.md) file. <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: 3032cbe50267d3f0102c450be2749c09fb3992bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: