export console remote schemas #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit dcc19c5 deployed to Heroku: https://hge-ci-pull-1165.herokuapp.com |
karthikvt26
previously approved these changes
Dec 5, 2018
Member
|
@praveenweb Lot of changes in package lock where |
Member
Author
|
@shahidhk - Seems to be an issue - npm/npm#20106 Anyways, have modified package-lock to have https now. |
karthikvt26
approved these changes
Dec 5, 2018
Contributor
|
Review app https://hge-ci-pull-1165.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
<!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> Add traces to `graphql-ws` crate. Since websockets are implemented by running multiple parallel tasks, we are using span links to establish relation between traces emitted by those tasks. Refactor by moving code into new modules and updating function names and types. ### How - Define a new `in_span_async_with_link()` in tracing-util to enable creating a span with a link. - Wrap spans around necessary code sections with attaching required attributes. - Small no-op refactor in `common.rs` test file. <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: 33cd313b94421097f3c1bb1bcf165f04c1a9cd65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: