这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Dec 4, 2018

Description

  1. Get rid of the HDBQuery type class
  2. Lazily acquire a connection from the pool

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

Review app for commit 6864cb9 deployed to Heroku: https://hge-ci-pull-1163.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1163-6864cb9

@rakeshkky rakeshkky added the c/server Related to server label Dec 5, 2018
@hasura-bot
Copy link
Contributor

Review app for commit 6c2ac32 deployed to Heroku: https://hge-ci-pull-1163.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1163-6c2ac32

@hasura-bot
Copy link
Contributor

Review app for commit aa10de2 deployed to Heroku: https://hge-ci-pull-1163.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1163-aa10de2

@hasura-bot
Copy link
Contributor

Review app for commit 0274aad deployed to Heroku: https://hge-ci-pull-1163.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1163-0274aad

@0x777 0x777 requested a review from rakeshkky December 12, 2018 09:32
@hasura-bot
Copy link
Contributor

Review app for commit fc69e1f deployed to Heroku: https://hge-ci-pull-1163.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1163-fc69e1f

@hasura-bot
Copy link
Contributor

Review app for commit f0076e1 deployed to Heroku: https://hge-ci-pull-1163.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1163-f0076e1

@0x777 0x777 merged commit ec8b2c8 into hasura:master Dec 13, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1163.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Sep 30, 2024
…sponses (#1163)

<!-- The PR description should answer 2 important questions: -->

### What

Fixes:
https://linear.app/hasura/issue/ENG-1073/figure-out-whats-causing-the-slowdown-in-response-processing

This removes the accidentally-quadratic behavior of repeated
nested `from_value`/`to_value` calls where the assumption seems to have
been
that ndc model fields containing Value would be untouched (similar to
the behavior of aeson).

### How

We work with `Value` directly instead of using `serde` machinery to get
a `RowSet`.

#### Benchmarks

The large result query shows modest latency improvement:

![image](https://github.com/user-attachments/assets/65d300ed-ad44-466a-bce2-950b305b02b3)

A query with a response of the same size as above, but with deep nesting
to trigger quadratic behavior shows significant latency improvement
(~12ms to ~2ms for `process_response` span)

![image](https://github.com/user-attachments/assets/355f8e96-a363-4523-a9df-850aba8edb8a)

Small responses (common, historically) don't show any improvement, as
they don't exhibit the issue.

V3_GIT_ORIGIN_REV_ID: f709e4f8a370b46c53f533eef2fef7e772b5cb72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants