这是indexloc提供的服务，不要输入任何密码
Skip to content

use postgres IN experssion for _in operator (fix #1109) #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2018
Merged

use postgres IN experssion for _in operator (fix #1109) #1111

merged 2 commits into from
Nov 26, 2018

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Nov 25, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #1109

Solution and Design

Use Postgresql IN expression instead of = ANY(ARRAY[..]) for _in operator in
where argument.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Nov 25, 2018
@rakeshkky rakeshkky added this to the v1.0.0-alpha31 milestone Nov 25, 2018
@rakeshkky rakeshkky self-assigned this Nov 25, 2018
@rakeshkky rakeshkky requested a review from 0x777 November 25, 2018 13:01
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 25, 2018

Review app for commit 78a3e8b deployed to Heroku: https://hge-ci-pull-1111.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1111-78a3e8b

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 26, 2018

Review app for commit d60c585 deployed to Heroku: https://hge-ci-pull-1111.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1111-d60c585

@shahidhk shahidhk merged commit 8df23ad into hasura:master Nov 26, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 26, 2018

Review app https://hge-ci-pull-1111.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

v1.0.0-alpha31

Development

Successfully merging this pull request may close these issues.

Regression: _in for UUID columns fails in alpha-29

4 participants

@rakeshkky @hasura-bot @0x777 @shahidhk