这是indexloc提供的服务，不要输入任何密码
Skip to content

move schema dropdown to top-left (close #1092) #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 11, 2019
Merged

move schema dropdown to top-left (close #1092) #1118

merged 17 commits into from
Jan 11, 2019

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Nov 26, 2018

fix #1092

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@wawhal wawhal requested review from 0x777 and praveenweb November 26, 2018 12:43
@shahidhk shahidhk added the c/console Related to console label Nov 27, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2018

Review app for commit 14dfd4a deployed to Heroku: https://hge-ci-pull-1118.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1118-14dfd4a

@praveenweb
Copy link
Member

praveenweb commented Dec 3, 2018

@wawhal - The UI seems to be messed up when i navigate to SQL page. Can you fix it?

@praveenweb praveenweb added the s/do-not-merge Do not merge this pull request to master label Dec 3, 2018
@praveenweb
Copy link
Member

praveenweb commented Dec 20, 2018

@wawhal - can you resolve the conflicts?

@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 8, 2019

Review app for commit dac77d3 deployed to Heroku: https://hge-ci-pull-1118.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1118-dac77d3

praveenweb
praveenweb requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh schema list under SQL tab after execution, so that it reflects in the dropdown instantly.

@wawhal wawhal removed the request for review from 0x777 January 10, 2019 11:18
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 10, 2019

Review app for commit 4bd3c22 deployed to Heroku: https://hge-ci-pull-1118.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1118-4bd3c22

@shahidhk shahidhk changed the title move schema dropdown to top-left move schema dropdown to top-left (close #1092) Jan 11, 2019
@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Jan 11, 2019
@shahidhk shahidhk merged commit 00dc868 into hasura:master Jan 11, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jan 11, 2019

Review app https://hge-ci-pull-1118.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

move the schema switching drop down to top left

5 participants

@wawhal @hasura-bot @praveenweb @shahidhk @surendran82