implement internal graphql server for remote schema tests #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app for commit 50f03b4 deployed to Heroku: https://hge-ci-pull-1117.herokuapp.com |
shahidhk
approved these changes
Nov 26, 2018
Contributor
|
Review app https://hge-ci-pull-1117.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
This removes the file `bahnql_query.yaml`, which is no longer being used. a509a86 (#1117) changed the way we test the remote schema feature from using external GraphQL services to running our own mini GraphQL server for testing purposes. This gives us a lot of in-codebase flexibility on the behavior of "remote" GraphQL servers. During this work, the `bahnql_query.yaml` test was swapped out for the `simple2_query.yaml` test. The former essentially tests if a field from a remote schema can be fetched, whereas the latter tests whether an entry can be fetched from the (non-remote!) database. It's not clear to me why `bahnql_query.yaml` was no longer used. In any case, the relevant setup code was removed, and this test can no longer be run. Presumably we test such basic functionality already in many other ways. hasura/graphql-engine-mono#2102 GitOrigin-RevId: c01b7f7
hasura-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
<!-- The PR description should answer 2 important questions: --> ### What Much like hasura/v3-engine#1116, make clearer what is and is not graphql-centric in engine by renaming `schema` to `graphql-schema`. ### How Moving file around, no functional changes. V3_GIT_ORIGIN_REV_ID: ec06c33a964c16a53c1a4ed306de3fdccd2e8efc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Added graphql server implemented in python for testing remote schemas.
Type
Checklist: