这是indexloc提供的服务，不要输入任何密码
Skip to content

fix tagging script to handle multiple directories #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2018
Merged

fix tagging script to handle multiple directories #1100

merged 2 commits into from
Nov 23, 2018

Conversation

@shahidhk
Copy link
Member

@shahidhk shahidhk commented Nov 22, 2018

[skip ci]

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@shahidhk shahidhk added the c/build-system Related to the build-release system label Nov 22, 2018
@shahidhk shahidhk added this to the v1.0.0-alpha30 milestone Nov 22, 2018
@arvi3411301 arvi3411301 self-requested a review November 23, 2018 13:12
@rikinsk-zz rikinsk-zz merged commit 45be696 into hasura:master Nov 23, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 23, 2018

Review app https://hge-ci-pull-1100.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Sep 16, 2024
@danieljharvey @hasura-bot
Checks for nested array capability (#1100)
9a265c0 
<!-- The PR description should answer 2 important questions: -->

### What

Forgot to add these checks when implementing the feature, so now they're
added as an issue / warning, which will be promoted to an error for new
projects.

### How

Check the data connector capabilities at the point a boolean expression
is used for either model filtering or as a command argument. Raise a
warning if missing.

V3_GIT_ORIGIN_REV_ID: 68ecca998f61aee9340de634223c1933613c36d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvi3411301 arvi3411301 arvi3411301 approved these changes

Assignees

No one assigned

Labels

c/build-system Related to the build-release system

Projects

None yet

Milestone

v1.0.0-alpha30

Development

Successfully merging this pull request may close these issues.

5 participants

@shahidhk @hasura-bot @arvi3411301 @rikinsk-zz @rikinsk