这是indexloc提供的服务，不要输入任何密码
Skip to content

enable updating event trigger from console (close #489) #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Dec 17, 2018
Merged

enable updating event trigger from console (close #489) #1124

merged 35 commits into from
Dec 17, 2018

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Nov 27, 2018

fix #489
Tests are WIP. Opening the PR for review.

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 28, 2018

Review app for commit 2df117b deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-2df117b

@shahidhk
Copy link
Member

shahidhk commented Nov 28, 2018

This UI needs overhauling to match with other tabs. like settings -> modify etc.

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 28, 2018

Review app for commit 7755b53 deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-7755b53

@shahidhk shahidhk added the c/console Related to console label Nov 29, 2018
@wawhal wawhal added the s/do-not-merge Do not merge this pull request to master label Nov 29, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 2, 2018

Review app for commit 70da1b6 deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-70da1b6

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 3, 2018

Review app for commit cbf4637 deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-cbf4637

tirumaraiselvan
tirumaraiselvan previously approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk
Copy link
Member

shahidhk commented Dec 14, 2018

@wawhal Can we show the headers in a table format instead of the JSON?

@wawhal wawhal added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Dec 14, 2018
@wawhal
Copy link
Contributor Author

wawhal commented Dec 14, 2018

@shahidhk tried that. Doesn't look good when there are more headers.

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 14, 2018

Review app for commit 297261f deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-297261f

karthikvt26
karthikvt26 requested changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wawhal toggle checkbox when clicked on the labels too

@wawhal wawhal removed the request for review from praveenweb December 15, 2018 05:31
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 15, 2018

Review app for commit d1164e5 deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-d1164e5

karthikvt26
karthikvt26 previously approved these changes Dec 15, 2018
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk changed the title enable updating event trigger from console enable updating event trigger from console (close #489) Dec 16, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 16, 2018

Review app for commit f167548 deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-f167548

@shahidhk shahidhk requested a review from dsandip December 17, 2018 06:47
dsandip
dsandip requested changes Dec 17, 2018
View reviewed changes
Copy link
Member

@dsandip dsandip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like one tiny change: Add Delete this trigger and create another one if you need to edit any of these fields. to the tooltip next to Info.

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 17, 2018

Review app for commit 96ad349 deployed to Heroku: https://hge-ci-pull-1124.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1124-96ad349

@shahidhk shahidhk merged commit 9d8ac86 into hasura:master Dec 17, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 17, 2018

Review app https://hge-ci-pull-1124.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Sep 19, 2024
@danieljharvey @hasura-bot
Wrap ModelSource and CommandSource in Arc (#1124)
7792795 
<!-- The PR description should answer 2 important questions: -->

### What

To avoid lifetime issues we are wrapping types we reuse throughout
`graphql_ir` and `execute::plan` in `Arc`. This PR does not remove the
later lifetimes, just does the first mechanical step in
`metadata_resolve`

### How

Wrap `ModelSource` and `CommandSource` in `Arc`, fix type errors.
Functional no-op.

V3_GIT_ORIGIN_REV_ID: af91ec7eedf9fe5c3c2fe9737f9c827c1f826d63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsandip dsandip dsandip requested changes

@shahidhk shahidhk shahidhk approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan left review comments

@karthikvt26 karthikvt26 karthikvt26 left review comments

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add event trigger update ui to console

8 participants

@wawhal @hasura-bot @shahidhk @tirumaraiselvan @dsandip @karthikvt26 @praveenweb @surendran82